-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc_sixlowpan_frag: initial import of SRF parameters #12220
Merged
miri64
merged 1 commit into
RIOT-OS:master
from
miri64:gnrc_sixlowpan_frag/feat/srf-config
Nov 7, 2019
Merged
gnrc_sixlowpan_frag: initial import of SRF parameters #12220
miri64
merged 1 commit into
RIOT-OS:master
from
miri64:gnrc_sixlowpan_frag/feat/srf-config
Nov 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: network
Area: Networking
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
labels
Sep 13, 2019
miri64
force-pushed
the
gnrc_sixlowpan_frag/feat/srf-config
branch
from
October 28, 2019 12:22
57cf167
to
c8714f8
Compare
Rebased to current master and adapted to version 07 of the draft. |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 31, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 4, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 5, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 6, 2019
Feel free to squash. |
miri64
force-pushed
the
gnrc_sixlowpan_frag/feat/srf-config
branch
from
November 7, 2019 08:50
fd08f1f
to
d5424e4
Compare
Squashed. |
miri64
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Nov 7, 2019
benpicco
reviewed
Nov 7, 2019
benpicco
reviewed
Nov 7, 2019
This imports the protocol parameters for Selective Fragment Recovery (SFR). For the values I took some educated guesses based on my experience with previous experimentation with fragment forwarding. The defines currently are based on [draft v7]. [draft v7]: https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-07#section-7.1 fixup! gnrc_sixlowpan_frag: initial import of SRF parameters
miri64
force-pushed
the
gnrc_sixlowpan_frag/feat/srf-config
branch
from
November 7, 2019 11:16
d5424e4
to
da74936
Compare
Fixed spelling errors and amended them directly. |
benpicco
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only adds defines, no functional changes.
If it helps you to have this merged independent of #12648 then go ahead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: network
Area: Networking
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This imports the protocol parameters for Selective Fragment Recovery (SFR). For the values I took some educated guesses based on my experience with previous experimentation with fragment forwarding.
The defines currently are based on draft v7.
Testing procedure
This just introduces some defines and their documentation. So
and read ;-).
Issues/PRs references
None