Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_sixlowpan_frag: initial import of SRF parameters #12220

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Sep 13, 2019

Contribution description

This imports the protocol parameters for Selective Fragment Recovery (SFR). For the values I took some educated guesses based on my experience with previous experimentation with fragment forwarding.

The defines currently are based on draft v7.

Testing procedure

This just introduces some defines and their documentation. So

make doc

and read ;-).

Issues/PRs references

None

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Sep 13, 2019
@miri64 miri64 requested a review from benpicco October 28, 2019 11:10
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/feat/srf-config branch from 57cf167 to c8714f8 Compare October 28, 2019 12:22
@miri64
Copy link
Member Author

miri64 commented Oct 28, 2019

Rebased to current master and adapted to version 07 of the draft.

miri64 added a commit to miri64/RIOT that referenced this pull request Oct 31, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 1, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 1, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 1, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 1, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 4, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 5, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 6, 2019
@benpicco
Copy link
Contributor

benpicco commented Nov 7, 2019

Feel free to squash.

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/feat/srf-config branch from fd08f1f to d5424e4 Compare November 7, 2019 08:50
@miri64
Copy link
Member Author

miri64 commented Nov 7, 2019

Squashed.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 7, 2019
This imports the protocol parameters for Selective Fragment Recovery
(SFR). For the values I took some educated guesses based on my
experience with previous experimentation with fragment forwarding.

The defines currently are based on [draft v7].

[draft v7]: https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-07#section-7.1

fixup! gnrc_sixlowpan_frag: initial import of SRF parameters
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/feat/srf-config branch from d5424e4 to da74936 Compare November 7, 2019 11:16
@miri64
Copy link
Member Author

miri64 commented Nov 7, 2019

Fixed spelling errors and amended them directly.

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only adds defines, no functional changes.
If it helps you to have this merged independent of #12648 then go ahead.

@miri64 miri64 merged commit a132b2b into RIOT-OS:master Nov 7, 2019
@miri64 miri64 deleted the gnrc_sixlowpan_frag/feat/srf-config branch November 7, 2019 13:13
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants