Skip to content

Commit

Permalink
Merge #19856
Browse files Browse the repository at this point in the history
19856: tests/net/gcoap_fileserver: Fix failing nightlies r=benpicco a=MrKevinWeiss


### Contribution description

This test has been failing inconsistently in the nightlies and sometimes on unrelated PRs. I was able to reproduce it with murdock and as soon as I added some print statements to the test it went away.  Since the issue is something to do with a failure when comparing 2 files after a node sends a file I am guessing that the comparison comes occasionally too fast and the file is not ready.

Maybe there is some more synchronization needed after a `ncput` but for now just adding a small sleep should prevent this issue.


### Testing procedure

Run murdock multiple times or try to get it failing on a local setup then apply the PR...


### Issues/PRs references



Co-authored-by: MrKevinWeiss <weiss.kevin604@gmail.com>
  • Loading branch information
bors[bot] and MrKevinWeiss authored Aug 3, 2023
2 parents 63062aa + 653bd61 commit bb9011c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tests/net/gcoap_fileserver/tests/01-run.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ def test_linear_topology(factory, zep_dispatch):
# upload the file to node B (only one node should write MEMORY.bin)
A.cmd("ncput /const/song.txt coap://[" + global_addr(B.cmd("ifconfig 7"))[1] + "]/vfs/song2.txt", timeout=60)

# It seems like failures may occur due to the `ncput` command finishing but
# the data not being written to the file yet. Therefore, we wait a bit...
# This is just a guess though.
time.sleep(0.5)

# make sure the content matches
assert B.cmd("md5sum /nvm0/song.txt").split()[2] == B.cmd("md5sum /nvm0/song2.txt").split()[2]

Expand Down

0 comments on commit bb9011c

Please sign in to comment.