-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove /plans/upstream
, replace it with CONTEST_CONTENT_LATEST
#145
Conversation
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
`CONTEST_CONTENT` to point to it. | ||
- Essentially, this is like `CONTEST_CONTENT` but without you having to | ||
provide a cloned directory, Contest automatically clones it for you. | ||
- Do not specify `CONTEST_CONTENT` in combination with this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also mention to not specify in combination CONTEST_CONTENT_PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to go the route of mentioning every possible variable combination with every other one. It occurred to me that I could mention it, but when we add more (conflicting) variables, we would have to create a matrix of which variable cannot be used with which other ones, and document it.
Instead, I would prefer to rely on common sense that is implied by the explanation - the PR text describes how it differs from LATEST, implying both are mutually exclusive.
use one or the other. | ||
- This is like `CONTEST_CONTENT_LATEST`, but instead of using the default | ||
branch, it checks out repository contents specific to the pull request. | ||
- Do not specify `CONTEST_CONTENT` in combination with this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention to not specify in combination with CONTEST_CONTENT_LATEST
docs/TESTS.md
Outdated
|
||
These specifically | ||
|
||
1. harden the OS installation via some means (`oscap`, Ansible, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It look weird when oscap is as code (oscap
) and Ansible not. I'd prefer it unified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I've replaced it with non-code OpenSCAP.
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
This is useful when trying to figure out where the datastream came from, eg. whether CONTEST_CONTENT works. Signed-off-by: Jiri Jaburek <comps@nomail.dom>
This fixes #141 - see it for rationale behind this change.
Also, you might want to review by commits - there have been two other smaller unrelated changes.