Integrating comments #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmartinol
commented
May 10, 2024
dmartinol
commented
- call do_put only once
- postpone the invocation of do_put
- simplified _make_flight_info
…ed _make_flight_info
tokoko
reviewed
May 10, 2024
| historical_flight_descriptor = fl.FlightDescriptor.for_command(self.command) | ||
| # TODO add one specialized implementation for each OfflineStore API | ||
| # This can result in a dictionary of functions indexed by api (e.g., "get_historical_features") | ||
| def _put_parameters(self, command_descriptor, command): |
There was a problem hiding this comment.
I was tempted to keep it for further extensions but in the spirit of keeping the code clean, I removed it, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.