Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ubi mapping for base image recommendation #313

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

xieshenzh
Copy link
Contributor

Create image mapping for recommending UBI and update the html report template.

Jira: https://issues.redhat.com/browse/APPENG-2274

olavtar and others added 2 commits March 18, 2024 17:12
…or Dockerfile base images

Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
@xieshenzh xieshenzh marked this pull request as ready for review March 19, 2024 01:24
@xieshenzh xieshenzh requested review from olavtar and ruromero March 19, 2024 01:24
@@ -35,4 +35,13 @@ quarkus.rest-client.segment-api.url=https://api.segment.io/
quarkus.management.enabled=true
quarkus.http.limits.max-body-size=4G

trustedcontent.recommended.ubi=pkg:oci/registry.access.redhat.com/ubi9/ubi@latest
trustedcontent.recommendation.ubi.purl.ubi9=pkg:oci/ubi@sha256:f5983f7c7878cc9b26a3962be7756e3c810e9831b0b9f9613e6f6b445f884e74?repository_url=registry.access.redhat.com/ubi9/ubi&tag=9.3-1552&arch=amd64
trustedcontent.recommendation.ubi.catalogurl.ubi9=https://catalog.redhat.com/software/containers/ubi9/ubi/615bcf606feffc5384e8452e?architecture=amd64&image=65a82982a10f3e68777870b5f
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olavtar I moved the configurations for the links to application.properties

@xieshenzh
Copy link
Contributor Author

@ruromero @olavtar I don't have access to the Konflux pipeline.
Could you take a look and let me know why it failed?

@ruromero
Copy link
Collaborator

/retest

Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieshenzh xieshenzh merged commit 23ec1e8 into RHEcosystemAppEng:main Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants