feat: cloud provider lib implementation #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
reviewed
Jan 28, 2025
vbelouso
requested changes
Jan 28, 2025
vbelouso
changed the title
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
…ests for better performance Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
…r check; Vars renaming to prevent name collision; fixed comments typos Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
|
Requested changes included. Please check it again. Thanks!! |
|
/lgtm |
|
Great job! |
r2dedios
added a commit
that referenced
this pull request
Feb 4, 2025
* chore: first working verison of cloud-provider lib Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * feat: add Helm chart (#101) (#102) * feat: add Helm chart * chore: fix formatting, Chart version, etc --------- Signed-off-by: Vladimir Belousov <vbelouso@redhat.com> Co-authored-by: Vladimir Belousov <89217163+vbelouso@users.noreply.github.com> * chore: First approach for CloudAgent Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * chore: First gRPC Agent approach Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * chore: Modified API for including Power on/off handlers; Created AgentServer and clients objects for better coding Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * chore: Updated compose devel deployment Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: Error on Makefile Doc string Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * feat: Added generic error on the API responses; Refactor Handlers file Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: Removed response from HandlerRefreshInventory due to multiple HTTP responses causing errors on the Console Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: comments copy-paste wrong Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: Removed unused logger from AWSConnection Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: Removed logger from AWSConnection creation Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * doc: Corrected and Improved AWSBillingStocker comments Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * doc: Corrected typo Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * refactor: Improved EC2 instance get operation by using paginated requests for better performance Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * refactor: simplified NewAWSConnection creation removing not used error check; Vars renaming to prevent name collision; fixed comments typos Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * doc: Fixed several typos on comments Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * feat: cloud provider lib implementation (#103) feat: cloud provider lib implementation (#103) Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: Replaced deprecated function 'grpc.Dial' by 'grpc.NewClient' Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: correctly determine EC2 instance creation timestamp Signed-off-by: Vladimir Belousov <vbelouso@redhat.com> * Release 0.3 rc 1 (#107) * doc: Updated project docs Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * build: Preparing release 0.3-rc-1 Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * doc: Added architecture diagram file and png image Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * doc: Updated README file with new components, config options and Helm chart installation Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * ci: Updated Helm Chart version tags Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> --------- Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * chore: reorganize server structure and improve shutdown handling (#113) * chore: reorganize server structure and improve shutdown handling Signed-off-by: Vladimir Belousov <vbelouso@redhat.com> * chore: reorganize router Signed-off-by: Vladimir Belousov <vbelouso@redhat.com> --------- Signed-off-by: Vladimir Belousov <vbelouso@redhat.com> * chore: minor improvements (typo, error wrapping, container build) (#111) Signed-off-by: Vladimir Belousov <vbelouso@redhat.com> * fix: Assigned CostExplorer service client connection correctly Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> * fix: typo on function 'setupSwagger' Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> --------- Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com> Signed-off-by: Vladimir Belousov <vbelouso@redhat.com> Co-authored-by: Vladimir Belousov <89217163+vbelouso@users.noreply.github.com> Co-authored-by: Vladimir Belousov <vbelouso@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First approach for separating the cloud providers code from scanner and agent. This will allow us to use same library for interacting with public cloud providers, separate the cloud provider code from Cluster-iq code, and reuse it in the Agent and Scanner