Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.11 fixes #30

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

v0.11 fixes #30

wants to merge 13 commits into from

Conversation

zoedberg
Copy link
Collaborator

This PR updates the tests to the v0.11 fixes epic.

It shows how this epic is fixing known open bugs in v0.11.

The epic includes the following fixes/changes:

  • lint code with rust 1.84.0
  • extend the tapret_wlt_receiving_opret test
  • have contract commit to a single layer1
  • have contract commit to a close method
  • fix handling of RGB allocations on blinded UTXOs in case of a reorg
  • fix undetected double spend (inflation) during accept transfer
  • fix retrying the same blinded transfer
  • add altered submodules to be able to write tests simulating an attacker using modified code

The epic is still missing:

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.99%. Comparing base (d6c1603) to head (e970329).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   36.92%   36.99%   +0.06%     
==========================================
  Files         279      279              
  Lines       42804    42928     +124     
==========================================
+ Hits        15805    15880      +75     
- Misses      26999    27048      +49     
Flag Coverage Δ
rust 36.99% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky
Copy link
Member

@zoedberg thank you

Can you please create a single tracking issue in rgb repo (like other tracking issues there) so it is easy to track the reviews and merging of all these many PRs?

@zoedberg
Copy link
Collaborator Author

Sure, done here RGB-WG/rgb#277.

@dr-orlovsky What about the branch I asked you to push? Could you please give me the permission to push branches on https://github.com/RGB-WG/rgb so that I do not bother you every time I have to update an altered branch?

@dr-orlovsky
Copy link
Member

@zoedberg sorry I can't even recall this matter... Too much stuff..

Github permissions are weird and constantly change. I added Core Devs (a group where you in) as maintainers to rgb repo. Hope that helps.

@zoedberg
Copy link
Collaborator Author

Yep, that helped, thank you! Now the altered repo is not pointing to my fork anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants