This repository has been archived by the owner on Dec 9, 2023. It is now read-only.
revert electrum-client usage temporary fix #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
ACK f8c9895
Is the RC2 release with this needed, or there are other things we need to get into RC2?
|
@dr-orlovsky I don't think we need other things, everything is working well on the 0.9 RC stack |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts most of the code introduced in #227.
Since the upgrade of the electrum-client lib in rgb-node we do not need that temporary fix anymore.
I haven't simply reverted the PR commit because that also added a timeout to the electrum client configuration that I think will be useful (maybe in the future we could also allow changing that value via config, we could open a "good first issue" for this).