-
-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d1c8a56
Thank you for fixing! Can I release v0.8.2
or you need more testing before that?
@dr-orlovsky I've just checked all rgb-node and rgb-lib dependencies on https://docs.rs/ and I've found only another library, lnp-core, for which documentation build fails. I think that we need to fix that before releasing a |
It seems that the problem was caused by releasing the library without [package.metadata.docs.rs]
features = ["all"] to the |
Fixed |
@dr-orlovsky lnp-core documentation build still fails: https://docs.rs/crate/lnp-core/0.8.1/builds/704364 |
That is strange. Had to read all rustdoc and docrs manuals, tried my best in LNP-WG/lnp-core#18. Let's see how that would work |
Holy cow, the docrs build finally worked! |
That's great! Thank you ❤️ |
Pls let me know if I can publish |
@dr-orlovsky I think you can go |
v0.8.2 released |
I've just noticed that also rgb-node documentation build fails.
This PR applies the same fix proposed here Storm-WG/storm-stored#8
@dr-orlovsky probably before releasing a v0.8.2 it's better if I check if there are other libraries we depend on that need the same fix, I'll let you know