Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract: add timestamp and issuer to genesis #211

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

dr-orlovsky
Copy link
Member

Implements RGB-WG/RFC#1 and RGB-WG/RFC#2

@dr-orlovsky dr-orlovsky added the feature NEw feature request label Feb 27, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Feb 27, 2024
@dr-orlovsky dr-orlovsky added *consensus* Issues affecting distributed concensus *security* Issues affecting safety/security (include undefined behaviours) labels Feb 27, 2024
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is StrictHash supposed to hold a 32 byte x-only public key?

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 15.5%. Comparing base (916ff4f) to head (1342202).

Files Patch % Lines
src/contract/operations.rs 25.0% 3 Missing ⚠️
src/contract/commit.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #211   +/-   ##
======================================
  Coverage    15.5%   15.5%           
======================================
  Files          33      33           
  Lines        4158    4164    +6     
======================================
+ Hits          644     645    +1     
- Misses       3514    3519    +5     
Flag Coverage Δ
rust 15.5% <16.7%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky
Copy link
Member Author

@cryptoquick No. It is a tagged SHA256 hash of a strict-serialized data. More on it here: https://github.com/RGB-WG/rgb-core/blob/master/doc/Commitments.md (just search for StrictHash string)

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crisdut crisdut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dr-orlovsky dr-orlovsky merged commit fc36c39 into master Mar 4, 2024
18 of 21 checks passed
@dr-orlovsky dr-orlovsky self-assigned this Mar 16, 2024
@dr-orlovsky dr-orlovsky deleted the rcp/240227 branch April 18, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Issues affecting distributed concensus feature NEw feature request *security* Issues affecting safety/security (include undefined behaviours)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants