-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract: add timestamp and issuer to genesis #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is StrictHash supposed to hold a 32 byte x-only public key?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
======================================
Coverage 15.5% 15.5%
======================================
Files 33 33
Lines 4158 4164 +6
======================================
+ Hits 644 645 +1
- Misses 3514 3519 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@cryptoquick No. It is a tagged SHA256 hash of a strict-serialized data. More on it here: https://github.com/RGB-WG/rgb-core/blob/master/doc/Commitments.md (just search for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implements RGB-WG/RFC#1 and RGB-WG/RFC#2