Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair check results #997

Merged
merged 21 commits into from
Aug 2, 2021
Merged

Repair check results #997

merged 21 commits into from
Aug 2, 2021

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Aug 1, 2021

Just an test for checks

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (pleas link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

Github actions status checks are not reported for the commit from actions-user

  • What is the new behavior (if this is a feature change)?

Github actions status checks are reported for the commit from actions-user

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

sidey79 and others added 2 commits August 1, 2021 18:15
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #997 (48a2275) into master (f7c20ab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #997   +/-   ##
=======================================
  Coverage   58.75%   58.75%           
=======================================
  Files         109      109           
  Lines        8636     8636           
  Branches     1351     1351           
=======================================
  Hits         5074     5074           
  Misses       2638     2638           
  Partials      924      924           
Flag Coverage Δ
fhem 48.85% <100.00%> (ø)
modules 58.75% <100.00%> (ø)
perl 91.57% <ø> (ø)
unittests 58.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 61.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c20ab...48a2275. Read the comment docs.

@sidey79 sidey79 changed the title test checks Repair check results Aug 1, 2021
@sidey79 sidey79 self-assigned this Aug 1, 2021
@sidey79 sidey79 linked an issue Aug 2, 2021 that may be closed by this pull request
@sidey79 sidey79 merged commit d54e85e into master Aug 2, 2021
@sidey79 sidey79 deleted the test-checks branch August 2, 2021 20:20
@sidey79
Copy link
Contributor Author

sidey79 commented Aug 13, 2021

00_SIGNALduino.pm

SIGNALduino_calcRSSI check input parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github checks are failing if job is skipped
3 participants