Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bresser 5in1 2 - Rename readings windDirection, windDirectionText, windGust and windSpeed #995

Merged
merged 9 commits into from
Aug 1, 2021

Conversation

elektron-bbs
Copy link
Contributor

@elektron-bbs elektron-bbs commented Jul 28, 2021

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    other

  • What is the current behavior? (You can also link to an open issue here)
    Protokoll für Bresser 5CH Temp Hygro #607 (comment)

  • What is the new behavior (if this is a feature change)?
    Rename readings windDirection, windDirectionText, windGust and windSpeed.
    Change register 0x03, Design Note DN009 - FIFOTHR.ADC_RETENTION - CC1101 will wake up with optimal ADC settings for low data rate (≤ 100 kbps).

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

elektron-bbs and others added 2 commits July 28, 2021 20:53
14_SD_WS.pm - Rename readings windDirection, windDirectionText, windGust and windSpeed
SD_ProtocolData.pm - change register 0x03, Design Note DN009 - FIFOTHR.ADC_RETENTION - CC1101 will wake up with optimal ADC settings for low data rate (≤ 100 kbps)
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #995 (1598646) into master (4db827b) will decrease coverage by 32.82%.
The diff coverage is 0.00%.

❗ Current head 1598646 differs from pull request most recent head 91dfbf4. Consider uploading reports for the commit 91dfbf4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #995       +/-   ##
===========================================
- Coverage   91.57%   58.75%   -32.83%     
===========================================
  Files          40      109       +69     
  Lines        2244     8636     +6392     
  Branches      138     1351     +1213     
===========================================
+ Hits         2055     5074     +3019     
- Misses         54     2638     +2584     
- Partials      135      924      +789     
Flag Coverage Δ
fhem 48.85% <0.00%> (?)
modules 58.75% <0.00%> (-32.83%) ⬇️
perl 91.57% <ø> (ø)
unittests 58.75% <0.00%> (-32.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_SD_WS.pm 54.73% <0.00%> (ø)
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
t/FHEM/14_SD_WS/09_parseDatat.t 80.00% <ø> (ø)
FHEM/10_FS10.pm 30.34% <0.00%> (ø)
t/FHEM/00_SIGNALduino/02_SIGNALduino_StartInit.t 100.00% <0.00%> (ø)
...M/00_SIGNALduino/02_SIGNALduino_CheckVersionResp.t 100.00% <0.00%> (ø)
t/FHEM/10_SD_GT/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/00_SIGNALduino/02_SIGNALduino_Get.t 100.00% <0.00%> (ø)
FHEM/90_SIGNALduino_un.pm 9.45% <0.00%> (ø)
FHEM/14_SD_WS09.pm 58.55% <0.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db827b...91dfbf4. Read the comment docs.

@sidey79 sidey79 linked an issue Jul 28, 2021 that may be closed by this pull request
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der Branch muss noch aktualisiert werden :)

@HomeAutoUser
Copy link
Contributor

Der Branch muss noch aktualisiert werden :)

Hast du doch schon vorgenommen :-D

HomeAutoUser referenced this pull request in RFD-FHEM/SIGNALduino_TOOL Jul 29, 2021
HomeAutoUser
HomeAutoUser previously approved these changes Jul 29, 2021
HomeAutoUser
HomeAutoUser previously approved these changes Jul 29, 2021
@sidey79
Copy link
Contributor

sidey79 commented Jul 29, 2021

Jetzt habe ich den Status Check irgendwie kaputt gemacht :(

change reading windDirection in windDirectionDegree
@elektron-bbs
Copy link
Contributor Author

Mhmm, beim letzten commit 1598646 liefen die Test noch fehlerfrei durch.
Jetzt steht da oben schon seit Stunden " Waiting for status to be reported"?

@sidey79
Copy link
Contributor

sidey79 commented Jul 30, 2021

Das liegt nicht an dir.
Ich hab das irgendwie kaputt gemacht :(

@elektron-bbs
Copy link
Contributor Author

OK, dann bin ich ja beruhigt :-)

@sidey79 sidey79 merged commit 433f038 into master Aug 1, 2021
@elektron-bbs elektron-bbs deleted the master_Bresser_5in1_2 branch September 8, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protokoll für Bresser 5CH Temp Hygro
4 participants