Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic update version date in string #989

Merged
merged 185 commits into from
Jul 29, 2021
Merged

Automatic update version date in string #989

merged 185 commits into from
Jul 29, 2021

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jul 9, 2021

controls update workflow will now run only if there is no pull request open.
This will also prevent updating the changed files for every commit, as soon there is a pull request opened :)

a new workflow will run on pull requests an update date/time and author in the ID line and VERSION String for 00_SIGNALduino
This will also update controls file as we might change filesize

The CHANGED file not be updated for every push. The changed file will updated once in the master branch after the merge
(this is tested the first time, we merge this Pull Request)

new workflow to change version datestring for pull requests
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #989 (7950d57) into master (5132552) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7950d57 differs from pull request most recent head 4df42d3. Consider uploading reports for the commit 4df42d3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files         108      108           
  Lines        8611     8611           
  Branches     1348     1348           
=======================================
  Hits         5054     5054           
  Misses       2639     2639           
  Partials      918      918           
Flag Coverage Δ
fhem 48.74% <100.00%> (ø)
modules 58.69% <100.00%> (ø)
perl 91.57% <ø> (ø)
unittests 58.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 61.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5132552...4df42d3. Read the comment docs.

@sidey79 sidey79 changed the title Automatic update version date in string WIP: Automatic update version date in string Jul 9, 2021
@sidey79
Copy link
Contributor Author

sidey79 commented Jul 9, 2021

@HomeAutoUser
@elektron-bbs

Ich habe da mal was eingebaut, damit das Datum im Versionsstring automatisch aktualisiert wird:
88d6ef4

Zeitzone ist halt wohl USA, daher steht da jetzt der 09.10 obwohl wir schon den 10.07 haben :)

HomeAutoUser
HomeAutoUser previously approved these changes Jul 10, 2021
Copy link
Contributor

@HomeAutoUser HomeAutoUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Von mir aus gern :)
Wenn wir wissen das der String automatisch gesetzt wird, so können wir ja das gern auch als Kommentar drüber schreiben oder wenn es auch geht, dahinter. Das erleichtert uns das durchsehen in Jahren / Jahrzehnten :D

@sidey79 sidey79 changed the title WIP: Automatic update version date in string Automatic update version date in string Jul 13, 2021
@sidey79
Copy link
Contributor Author

sidey79 commented Jul 14, 2021

@HomeAutoUser

Ich denke ich bin fertig.
Die Checks sind gelaufen, aber hier ist die Anzeige irgendwie gestört.

Im Wensentlichen:

CHANGED wird mit dem commit Text aus dem Pull Request aktualisiert. Sobald wir den Branch mergen, sehen wir ob es wirklich funktioniert :)

Die ID Zeile und der Version String werden hinsichtlich Datum / Zeit / Author aktualisiert

Das Pull Request Template habe ich angepasst.

@sidey79 sidey79 closed this Jul 18, 2021
@sidey79 sidey79 reopened this Jul 18, 2021
@sidey79
Copy link
Contributor Author

sidey79 commented Jul 28, 2021

@HomeAutoUser

Bräuchte hier noch mal das go

@sidey79 sidey79 merged commit b8aa183 into master Jul 29, 2021
@sidey79 sidey79 deleted the update-version-date branch July 29, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants