Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes perlcritic return undef; #979

Merged
merged 20 commits into from
Aug 11, 2021
Merged

Fixes perlcritic return undef; #979

merged 20 commits into from
Aug 11, 2021

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jun 7, 2021

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)

Fix some perlcritic messages

return undef;
replaced to
return ;

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #979 (3d7734e) into master (a3a967a) will not change coverage.
The diff coverage is 34.78%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #979   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         217      217           
  Lines       15184    15184           
  Branches     2841     2841           
=======================================
  Hits         7517     7517           
  Misses       6051     6051           
  Partials     1616     1616           
Flag Coverage Δ
fhem 49.32% <34.78%> (ø)
modules 49.50% <34.78%> (ø)
perl 50.79% <ø> (ø)
unittests 49.50% <34.78%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_BresserTemeo.pm 9.16% <0.00%> (ø)
FHEM/14_SD_RSL.pm 10.43% <0.00%> (ø)
FHEM/14_SD_WS09.pm 58.55% <22.22%> (ø)
FHEM/14_SD_WS.pm 55.60% <80.00%> (ø)
FHEM/41_OREGON.pm 28.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a967a...3d7734e. Read the comment docs.

@sidey79 sidey79 changed the title Fixex perlcritic return undef; Fixes perlcritic return undef; Jun 21, 2021
@sidey79 sidey79 requested review from elektron-bbs and HomeAutoUser and removed request for elektron-bbs August 10, 2021 19:04
HomeAutoUser
HomeAutoUser previously approved these changes Aug 10, 2021
@elektron-bbs
Copy link
Contributor

Durch die vielen Änderungen zwischendurch ist wahrscheinlich von deinem ursprünglich geplanten Fix zumindest im Modul 14_SD_WS.pm nicht viel angekommen. Die anderen Module habe ich mir nicht näher angesehen.

@sidey79
Copy link
Contributor Author

sidey79 commented Aug 10, 2021

Das wäre möglich, oder die Return undef kommen da nicht (mehr) vor.

@sidey79
Copy link
Contributor Author

sidey79 commented Aug 10, 2021

Dummerweise wollte der Branche aktualisiert werden.
@HomeAutoUser

Früher ist mir das out-of-date nie aufgefaen.

@sidey79 sidey79 merged commit 4b92b72 into master Aug 11, 2021
@sidey79 sidey79 deleted the critics branch August 11, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants