Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions-setup-perl install method to install cpan modules #967

Merged
merged 6 commits into from
May 26, 2021

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented May 18, 2021

Update install method of cpan packages

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This changes the way we install cpan modules during our github actions workflow.
The actions-setup-perl action is used to install cpan modules specified in our cpanfile. This brings us caching of cpan modules which speeds up the wokflow a little bit.

  • What is the current behavior? (You can also link to an open issue here)

cpan modules are installed via shell commands and are downloaded and installed for every run

  • What is the new behavior (if this is a feature change)?

cpan modules are installed via actions-setup-perl
installed cpan modules are cached
all needed cpan modules are specified in cpanfile

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

Only for unittesting

Update install method of cpan packages
@sidey79 sidey79 changed the title Update prove.yml Use actions-setup-perl install method to install cpan modules May 18, 2021
Fix syntax
Added Clover package removed coveralls package
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #967 (2b6812e) into master (e7c792e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   58.37%   58.37%           
=======================================
  Files         106      106           
  Lines        8485     8485           
  Branches     1323     1323           
=======================================
  Hits         4953     4953           
  Misses       2638     2638           
  Partials      894      894           
Flag Coverage Δ
fhem 48.56% <ø> (ø)
modules 58.37% <ø> (ø)
perl 91.54% <ø> (ø)
unittests 58.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c792e...2b6812e. Read the comment docs.

Install cpan modules only via cpanfile
@sidey79 sidey79 requested a review from HomeAutoUser May 18, 2021 21:18
@sidey79 sidey79 marked this pull request as ready for review May 18, 2021 21:19
@sidey79
Copy link
Contributor Author

sidey79 commented May 22, 2021

@HomeAutoUser

Kannst Du das Review machen? Wenn nicht, kann ja ggf. auch @elektron-bbs mal draufschauen.

@sidey79
Copy link
Contributor Author

sidey79 commented May 26, 2021

@elektron-bbs
Könntest Du das review übernehmen?

@elektron-bbs
Copy link
Contributor

Von mir aus gern, aber ich bin bei reviewers nicht gelistet.
@HomeAutoUser sollte eigentlich auch wieder aktiv sein.

@sidey79 sidey79 requested a review from elektron-bbs May 26, 2021 19:53
@HomeAutoUser
Copy link
Contributor

@sidey79
ich schaute drüber und mir fiel nichts auf an Syntax.
Was der Code aber dann macht oder bezweckt, kann ich nur erahnen. ;-)

@sidey79
Copy link
Contributor Author

sidey79 commented May 26, 2021

Der code installiert die im cpanfile hinterlegten Module über die action und nicht mehr per direktem cpan Befehlsaufruf.

Hattest Du das erahnt?

Wenns passt, dann wäre ein approve sehr schön

Copy link
Contributor

@HomeAutoUser HomeAutoUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In der Art erahnte ich es. Das etwas installiert wird.

@sidey79 sidey79 merged commit 1ae90e9 into master May 26, 2021
@sidey79 sidey79 deleted the update-cpan-install-method branch May 26, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants