Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittest error in actions and failing SIGNALduino_CheckVersionResp test #923

Merged
merged 7 commits into from
Dec 28, 2020

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Dec 27, 2020

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bugfix

  • What is the current behavior? (You can also link to an open issue here)

SIGNALduino_CheckVersionResp does always apply variable $1 to $hash->{version} even if the regex doen't find any version.
Then it uses the last value which is stored in $1.

  • What is the new behavior (if this is a feature change)?

$hash->{version} does only receive an variable assignent if the regex for searching a version number has a match

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

Fixed also the error report in the classic unittests

sidey79 and others added 3 commits December 27, 2020 23:30
- try to catch error in classic tests

(cherry picked from commit 657680e)
 -Wrong version assignment in SIGNALduino_CheckVersionResp fixed and tests corrected
@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #923 (e9fb6f2) into master (86f7898) will increase coverage by 2.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   53.72%   55.98%   +2.26%     
==========================================
  Files          54       66      +12     
  Lines        5279     8050    +2771     
  Branches      743     1291     +548     
==========================================
+ Hits         2836     4507    +1671     
- Misses       2054     2709     +655     
- Partials      389      834     +445     
Flag Coverage Δ
fhem 91.37% <ø> (ø)
modules 91.37% <ø> (ø)
perl 91.37% <ø> (ø)
unittest 55.98% <66.66%> (+2.26%) ⬆️
unittests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 61.19% <66.66%> (+34.61%) ⬆️
FHEM/14_Hideki.pm 4.67% <0.00%> (ø)
FHEM/14_BresserTemeo.pm 9.56% <0.00%> (ø)
FHEM/10_SD_GT.pm 5.99% <0.00%> (ø)
FHEM/14_SD_WS09.pm 59.51% <0.00%> (ø)
FHEM/14_SD_WS07.pm 52.59% <0.00%> (ø)
FHEM/90_SIGNALduino_un.pm 9.45% <0.00%> (ø)
FHEM/14_SD_AS.pm 8.00% <0.00%> (ø)
FHEM/14_FLAMINGO.pm 48.30% <0.00%> (ø)
FHEM/14_SD_RSL.pm 39.13% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f7898...e9fb6f2. Read the comment docs.

@sidey79
Copy link
Contributor Author

sidey79 commented Dec 27, 2020

Shoud fix failing unittests in #918

@sidey79 sidey79 merged commit 4d8a7d8 into master Dec 28, 2020
@sidey79 sidey79 deleted the repair_unitest branch December 28, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants