Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for optional float in parse_mu #597

Merged
merged 2 commits into from
Jun 8, 2019
Merged

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jun 8, 2019

paese_MU:
fixed regex if float was not found as pattern. fixex 596

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bugfix of regex in parse_MU

  • What is the current behavior? (You can also link to an open issue here)
    If float is not found, the part of the regex instead is added.
    This causes that the regex ends with | whcih allows the capture group that no chat dies count for min_length

  • What is the new behavior (if this is a feature change)?

If a key (zero / float) is not returned, the regex will not be extendet.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Nothing known.

sidey79 and others added 2 commits June 8, 2019 23:26
paese_MU:
fixed regex if float was not found as pattern. fixex 596
@sidey79 sidey79 added the bug label Jun 8, 2019
@sidey79 sidey79 requested a review from HomeAutoUser June 8, 2019 21:29
@sidey79 sidey79 marked this pull request as ready for review June 8, 2019 21:29
@sidey79 sidey79 merged commit f782c84 into dev-r34 Jun 8, 2019
@sidey79 sidey79 deleted the dev-r34_floatfix branch June 8, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants