-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed prototypes #1145
Merged
Merged
Removed prototypes #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed prototypes
prototypes removed
prototypes removed
prototypes removed
prototypes removed
prototypes removed
…/RFFHEM into master-criticPrototypes
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 67.38% 67.23% -0.16%
==========================================
Files 137 135 -2
Lines 9828 9818 -10
Branches 1572 1572
==========================================
- Hits 6623 6601 -22
- Misses 1914 1926 +12
Partials 1291 1291
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elektron-bbs
previously approved these changes
Jan 9, 2023
Ich brauch ein neues Review wegen branch update |
elektron-bbs
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(You can also link to an open issue here, if this describes the current behavior)
perlcritic 5 finds many subroutine prototypes messages:
prototype warnings are removed
no