Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol 85, 115, 117 error windDirectionText #1111

Merged
merged 5 commits into from
Sep 4, 2022
Merged

Protocol 85, 115, 117 error windDirectionText #1111

merged 5 commits into from
Sep 4, 2022

Conversation

elektron-bbs
Copy link
Contributor

@elektron-bbs elektron-bbs commented Aug 5, 2022 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other

  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    Protocol 85, 115, 117 no windDirectionText if windDirectionDegree >= 349
    2022.08.05 16:59:19 3: sduino_dummy: SD_WS_85 Parse msg 0BFF0F02000163C10 - winddir=355
    2022.08.05 16:59:19 1: PERL WARNING: Use of uninitialized value in concatenation (.) or string at ./FHEM/14_SD_WS.pm line 689.

  • What is the new behavior (if this is a feature change)?
    windDirectionText OK

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

elektron-bbs and others added 2 commits August 5, 2022 21:00
@elektron-bbs
SD_WS Bugfix windDirectionText
d95a49d 
Protocol 85, 115, 117 no windDirectionText if windDirectionDegree >= 349
@actions-user
Automatic updated controls and CHANGED
2e86fbf
@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited
Loading

Codecov Report

Merging #1111 (ffd86f7) into master (f703903) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
- Coverage   64.82%   64.72%   -0.10%     
==========================================
  Files         133      133              
  Lines        9668     9668              
  Branches     1533     1533              
==========================================
- Hits         6267     6258       -9     
- Misses       2205     2214       +9     
  Partials     1196     1196
Flag Coverage Δ
fhem 56.63% <100.00%> (-0.11%) ⬇️
modules 64.72% <100.00%> (-0.10%) ⬇️
perl 90.37% <ø> (+0.08%) ⬆️
unittests 64.72% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_SD_WS.pm 65.47% <100.00%> (ø)
FHEM/00_SIGNALduino.pm 63.74% <0.00%> (-0.45%) ⬇️
t/FHEM/14_BresserTemeo/00_load.t
t/FHEM/14_SD_WS09/00_load.t 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elektron-bbs
Copy link
Contributor Author

@sidey79
Könntest du bitte den Review bestätigen, oder soll ich noch etwas ändern?

@HomeAutoUser HomeAutoUser mentioned this pull request Aug 31, 2022
Merged
7 tasks
@sidey79
Copy link
Contributor

sidey79 commented Sep 3, 2022

@elektron-bbs

Ich vermute ich habe nicht approved, weil der Haken bei den Tests fehlt.
Wenn ich das richtig verstehe, dann wurde ab einem bestimmten Grad (355?) nicht wieder Norden ausgegeben sondern eine Warning geschrieben.

Wenn das die dmsg 0BFF0F02000163C10 ist, wovon ich ausgehe, sollte es doch möglich sein, diese dmsg in unseren Testdaten zu hinterlegen und auf Windrichtung N zu prüfen.

@elektron-bbs
Copy link
Contributor Author

Ich habe die Nachricht in den Logs gefunden und zu den Testdaten hinzugefügt.

@sidey79
Copy link
Contributor

sidey79 commented Sep 4, 2022

Leider ist der Test nicht erfolgreich durchgelaufen, aber auf dem Handy finde ich die Stelle leidet nicht.

@elektron-bbs
Copy link
Contributor Author

Vermutlich laufen die Tests alle nicht mehr durch, weil schon Testdaten für diesen Pull request SD_UT RC Buttons_six #1114 hinterlegt sind, aber das Modul 14_SD_UT.pm noch nicht auf diesem Stand ist.

@sidey79
Copy link
Contributor

sidey79 commented Sep 4, 2022

@elektron-bbs

Ja das sieht so aus:

        # Failed test 'Verify device return from defmod '
Error:         # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/14_SD_UT/09_parseDatat.t line 32.
        # +---------------------------------+------------+-----------+-----+
        # | GOT                             | OP         | CHECK     | LNs |
        # +---------------------------------+------------+-----------+-----+
        # | wrong <model> Buttons_six\n     | !DEFINED() | UNDEFINED | 87  |
        # | \n                              |            |           |     |
        # | (allowed modelvalues: AC114_01B |            |           |     |
        # |  | BF_301 | BeSmart_S4 | Button |            |           |     |
        # | s_five | CAME_TOP_432EV | Chili |            |           |     |
        # | tec_22640 | HS1_868_BS | HSM4 | |            |           |     |
        # |  KL_RF01 | Krinner_LUMIX | LED_ |            |           |     |
        # | XM21_0 | MD_2003R | MD_2018R |  |            |           |     |
        # | MD_210R | Meikee_21 | Meikee_24 |            |           |     |
        # |  | Momento | Navaris | Novy_840 |            |           |     |
        # | 029 | Novy_840039 | OR28V | QUI |            |           |     |
        # | GG_DMV | RC_10 | RCnoName20 | R |            |           |     |
        # | H787T | SA_434_1_mini | SF01_01 |            |           |     |
        # | 319004 | SF01_01319004_Typ2 | T |            |           |     |
        # | C6861 | TR401 | TR60C1 | TR_502 |            |           |     |
        # | MSV | Techmar | Tedsen_SKX1xx | |            |           |     |
        # |  Tedsen_SKX2xx | Tedsen_SKX4xx  |            |           |     |
        # | | Tedsen_SKX6xx | Unitec_47031  |            |           |     |
        # | | Visivo | unknown | xavax)     |            |           |     |
        # +---------------------------------+------------+-----------+-----+
        # {
        #   "attributes" => {
        #                     "model" => "Buttons_six"
        #                   },
        #   "comment" => "remote with 6 buttons, with light dimmer, for example Westinghouse airfan",
        #   "dmsg" => "P29#DFE",
        #   "internals" => {
        #                    "DEF" => "Buttons_six E",
        #                    "NAME" => "Buttons_six_E"
        #                  },
        #   "minProtocolVersion" => "1.46",
        #   "readings" => {
        #                   "LastAction" => "receive",
        #                   "deviceCode" => "1110 (off|off|off|on)",
        #                   "state" => "light_dimm"
        #                 },
        #   "revision_entry" => "2022-08-30 21:14:56",
        #   "revision_modul" => "14_SD_UT.pm 0 2022-06-14 07:33:24Z HomeAutoUser",
        #   "rmsg" => "MU;P0=24164;P1=-495;P2=191;P3=-271;P4=415;P5=-8052;D=01212341212121212121212345212123412121212121212123452121234121212121212121234521212341212121212121212345212123412121212121212123452121234121212121212121234521212341212121212121212345212123412121212121212123452121234121212121212121234521212341212121212121;CP=2;R=52;O;",
        #   "user" => "monosurr0und"
        # }
        # Failed test 'verify parseFn return equal internal NAME'
Error:         # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/14_SD_UT/09_parseDatat.t line 32.
        # +-------------------------------------------+----+---------------+
        # | GOT                                       | OP | CHECK         |
        # +-------------------------------------------+----+---------------+
        # | UNDEFINED unknown_please_select_model SD_ | eq | Buttons_six_E |
        # | UT unknown                                |    |               |
        # +-------------------------------------------+----+---------------+
            # Failed test 'check reading state'
Error:             # at lib/Test2/SIGNALduino/RDmsg.pm line 125.
            # +---------+------------+
            # | GOT     | CHECK      |
            # +---------+------------+
            # | <UNDEF> | light_dimm |
            # +---------+------------+
            # Failed test 'check reading LastAction'
Error:             # at lib/Test2/SIGNALduino/RDmsg.pm line 125.
            # +---------+---------+
            # | GOT     | CHECK   |
            # +---------+---------+
            # | <UNDEF> | receive |
            # +---------+---------+
            # Failed test 'check reading deviceCode'
Error:             # at lib/Test2/SIGNALduino/RDmsg.pm line 125.
            # +---------+-----------------------+
            # | GOT     | CHECK                 |
            # +---------+-----------------------+
            # | <UNDEF> | 1110 (off|off|off|on) |
            # +---------+-----------------------+
        # Failed test 'Verify readings'
Error:         # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/14_SD_UT/09_parseDatat.t line 32.
            # Failed test 'check internal DEF'
Error:             # at lib/Test2/SIGNALduino/RDmsg.pm line 136.
            # +---------+---------------+
            # | GOT     | CHECK         |
            # +---------+---------------+
            # | <UNDEF> | Buttons_six E |
            # +---------+---------------+
            # Failed test 'check internal NAME'
Error:             # at lib/Test2/SIGNALduino/RDmsg.pm line 136.
            # +---------+---------------+
            # | GOT     | CHECK         |
            # +---------+---------------+
            # | <UNDEF> | Buttons_six_E |
            # +---------+---------------+
        # Failed test 'Verify internals'
Error:         # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/14_SD_UT/09_parseDatat.t line 32.
    # Failed test 'Checking parseFN for module: SD_UT device: HT12e TestNo: 0 (remote with 6 buttons, with light dimmer, for example Westinghouse airfan)'
Error:     # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/14_SD_UT/09_parseDatat.t line 32.

Ich nehme es temporär raus und später wieder mit rein

@sidey79 sidey79 merged commit 2d35b42 into master Sep 4, 2022
@sidey79 sidey79 deleted the master_SD_WS_windDirectionText branch September 4, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidey79 sidey79 sidey79 approved these changes

Assignees
No one assigned
Labels
SD_WS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elektron-bbs @sidey79 @actions-user