Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewdog for perl tests & errors - report unittest failure inline #1100

Merged
merged 58 commits into from
Oct 24, 2022

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Apr 24, 2022

Check perl errors and test results via reviewdog, to provide inline links to specific files.

don't push versiondate or changed back to repository if there is any failed check.

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
  1. Errors from unittests are not displayed inline, we have to seek them in the job log manual.
  2. Version and controls file are updated before tests have passed
  • What is the new behavior (if this is a feature change)?
  1. check status report of perl errors (perl-errors) and check status report if unittest is failing (perl-test2-tap)
  2. Version and control file upates will wait until successfull finished checks
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

I don't think so.

  • Other information:

Exampe of a failed test:

Direct test result, linking to exact place where the test failed:

image

Exampe of syntax error in a module:

A link brings us directly to the line where the error is reported.

image

add config for reviewdog
@sidey79 sidey79 self-assigned this Apr 24, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #1100 (101d9f8) into master (eccc246) will increase coverage by 0.42%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   64.66%   65.08%   +0.42%     
==========================================
  Files         135      138       +3     
  Lines        9723     9758      +35     
  Branches     1544     1547       +3     
==========================================
+ Hits         6287     6351      +64     
+ Misses       2221     2189      -32     
- Partials     1215     1218       +3     
Flag Coverage Δ
fhem 57.15% <66.66%> (+0.53%) ⬆️
modules 65.08% <66.66%> (+0.42%) ⬆️
perl 90.33% <ø> (+0.24%) ⬆️
unittests 65.08% <66.66%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/14_SD_WS/00_load.t 100.00% <ø> (ø)
FHEM/14_SD_WS07.pm 47.40% <66.66%> (ø)
t/FHEM/14_SD_BELL/00_load.t
t/FHEM/14_BresserTemeo/00_load.t
t/FHEM/14_SD_AS/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_FLAMINGO/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_SD_WS07/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/14_Hideki/00_load.t 100.00% <0.00%> (ø)
FHEM/14_SD_WS09.pm 73.07% <0.00%> (+8.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

prevent reviewdog run for canceled workflows

Update Versiondate

Update Versiondate

change changes back, after status checks have passed

change changes back, after status checks have passed

Update Versiondate

Update Versiondate
@sidey79 sidey79 force-pushed the test-reviewdog branch 3 times, most recently from 8408e47 to 43ed0f9 Compare October 23, 2022 11:13
@sidey79 sidey79 force-pushed the test-reviewdog branch 2 times, most recently from 13e38aa to ace0864 Compare October 23, 2022 12:27
@sidey79 sidey79 changed the title Test reviewdog - report unittest failure inline reviewdog for perl tests & errors - report unittest failure inline Oct 23, 2022
@sidey79 sidey79 marked this pull request as ready for review October 23, 2022 12:29
@sidey79 sidey79 merged commit d500a3a into master Oct 24, 2022
@sidey79 sidey79 deleted the test-reviewdog branch October 24, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants