Update {Match} regex for Hideki Module #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prüfung ergänzt, welche dmsg gegen den Match eintrag verifiziert
- Match Regex angepasst - Subs als Coderef hinterlegt
- ParseData Test mit Testdaten hinterlegt
- Weitere Testdaten ergänzt
Modul {Match} als Regex und nicht als string scalar speichern.
Codecov Report
@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
+ Coverage 62.18% 63.56% +1.38%
==========================================
Files 126 128 +2
Lines 9340 9363 +23
Branches 1476 1477 +1
==========================================
+ Hits 5808 5952 +144
+ Misses 2431 2280 -151
- Partials 1101 1131 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Closed
|
Warte auf #1065 |
Attributname angepasst
elektron-bbs
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(You can also link to an open issue here, if this describes the current behavior)
Sensors with less data like temperature only, are not matched by the {Match} regex.
As from FHEM Revision @25489 upwards, the .clientArray is no longer used for dispatch if a module is already loaded.
The {Match} regex accepts messages with less data, so the data will also be dispatched after the module has been loaded.
No
The {Match} regex is complied once the module is initalized and not for every check it's used by fhem