Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check order of rfmodes in test #1059

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Do not check order of rfmodes in test #1059

merged 1 commit into from
Jan 9, 2022

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jan 9, 2022

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

The test relies on the order of elements. Adding a rfmode needs extending the test.

#980

  • What is the new behavior (if this is a feature change)?

The order of elements is not checked
Also there can be more elements

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #1059 (33eb5d3) into master (bc455c2) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   61.36%   61.39%   +0.02%     
==========================================
  Files         127      127              
  Lines        9386     9406      +20     
  Branches     1486     1489       +3     
==========================================
+ Hits         5760     5775      +15     
- Misses       2545     2547       +2     
- Partials     1081     1084       +3     
Flag Coverage Δ
fhem 52.70% <ø> (+0.05%) ⬆️
modules 61.39% <ø> (+0.02%) ⬆️
perl 91.61% <ø> (ø)
unittests 61.39% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/00_SIGNALduino/00_SIGNALduino_initialize.t 100.00% <ø> (ø)
t/FHEM/14_FLAMINGO/00_load.t
t/FHEM/14_SD_BELL/09_parseDatat.t 80.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc455c2...33eb5d3. Read the comment docs.

@sidey79 sidey79 self-assigned this Jan 9, 2022
@sidey79 sidey79 linked an issue Jan 9, 2022 that may be closed by this pull request
@sidey79 sidey79 changed the title Do not check order of rfmodes Do not check order of rfmodes in test Jan 9, 2022
Copy link
Contributor

@elektron-bbs elektron-bbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ob es funktioniert sehe ich dann beim nächsten Protokoll :-)

@sidey79
Copy link
Contributor Author

sidey79 commented Jan 9, 2022

Ich habe es probiert :)

Was ist mit z.B. Besser 7in1 ginge der auch bei uns?

@sidey79 sidey79 merged commit cf1f65c into master Jan 9, 2022
@elektron-bbs
Copy link
Contributor

Ja, da bin ich dran...

@sidey79 sidey79 deleted the sidey79/issue980 branch January 23, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rfmode - from SD_ProtocolData.pm
2 participants