Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RSL module #1058

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Remove RSL module #1058

merged 3 commits into from
Jan 14, 2022

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jan 9, 2022

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

The RSL module is placed in two repositorys

  • What is the new behavior (if this is a feature change)?

The RSL module resides only in one repository:
https://github.com/fhem/mod_RSL

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

Codeupdates from here are updated on the other repository
fhem/mod_RSL#34

sidey79 and others added 2 commits January 9, 2022 12:23
RSL Modul entfernt, da das Modul ein eigenes Repository besitzt
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #1058 (b3e678c) into master (cf1f65c) will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
+ Coverage   61.32%   62.05%   +0.72%     
==========================================
  Files         125      126       +1     
  Lines        9376     9271     -105     
  Branches     1486     1462      -24     
==========================================
+ Hits         5750     5753       +3     
+ Misses       2545     2437     -108     
  Partials     1081     1081              
Flag Coverage Δ
fhem 53.26% <ø> (+0.67%) ⬆️
modules 62.05% <ø> (+0.72%) ⬆️
perl 91.83% <ø> (+0.21%) ⬆️
unittests 62.05% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/14_FLAMINGO/09_parseDatat.t
t/FHEM/14_SD_BELL/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/10_SD_GT/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_FLAMINGO/00_load.t 100.00% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.72% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1f65c...b3e678c. Read the comment docs.

@sidey79
Copy link
Contributor Author

sidey79 commented Jan 14, 2022

@HomeAutoUser
@elektron-bbs

Könnt ihr das Review machen?

@elektron-bbs elektron-bbs self-requested a review January 14, 2022 20:55
Copy link
Contributor

@elektron-bbs elektron-bbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du hattest mich zwar nicht vorgesehen, aber ich mache mal :-)

@sidey79 sidey79 merged commit c5b70a2 into master Jan 14, 2022
@HomeAutoUser
Copy link
Contributor

Danke @elektron-bbs.
Ich dachte es gemacht zu haben 😃

@sidey79 sidey79 deleted the rm-ModRSL branch January 23, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants