Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perlcritic Ergebnis bei jedem PR anzeigen #1054

Merged
merged 40 commits into from
Jan 15, 2022
Merged

Perlcritic Ergebnis bei jedem PR anzeigen #1054

merged 40 commits into from
Jan 15, 2022

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jan 6, 2022

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

initial commit for first test
workflow angepasst
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1054 (4918445) into master (c5b70a2) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   61.93%   62.04%   +0.11%     
==========================================
  Files         125      128       +3     
  Lines        9266     9341      +75     
  Branches     1462     1471       +9     
==========================================
+ Hits         5739     5796      +57     
- Misses       2446     2455       +9     
- Partials     1081     1090       +9     
Flag Coverage Δ
fhem 53.39% <100.00%> (+0.25%) ⬆️
modules 62.04% <100.00%> (+0.11%) ⬆️
perl 91.61% <ø> (-0.14%) ⬇️
unittests 62.04% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 63.00% <100.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.15% <0.00%> (-0.35%) ⬇️
t/FHEM/14_SD_WS07/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/14_SD_BELL/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/41_OREGON/09_parseData.t 80.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b70a2...4918445. Read the comment docs.

@sidey79 sidey79 changed the title Perlcritic Ergebnus bei jedem PR anzeigen Perlcritic Ergebnis bei jedem PR anzeigen Jan 6, 2022
sidey79 and others added 9 commits January 7, 2022 00:22
install less critic modules
limitierung der policys auf security , bugs und pbp
- Fehler zu demo Zwecken eingebaut
Filter auf geänderte Dateien umgestellt
removed themes to get all sev 5 findings
@sidey79 sidey79 added unittest Perl::Critic code revisions labels Jan 8, 2022
sidey79 and others added 14 commits January 8, 2022 22:16
This reverts commit 2cca269.
added themes and extended to core theme
list all policys
exclude maintenance theme from critic run
Update workflow version for setup Perl
remove bangs from perlcritic check
Format angepasst, damit pbp Referenz mit ausgegeben wird.
@sidey79
Copy link
Contributor Author

sidey79 commented Jan 8, 2022

Beipsielcode:

image

Liefert diese beiden Findings im critic-report:
image

Und in der Kommentierung folgende details:

image

Links sind klickbar und führen zur richtigen Codezeile

@sidey79 sidey79 marked this pull request as ready for review January 8, 2022 22:47
@sidey79
Copy link
Contributor Author

sidey79 commented Jan 14, 2022

@HomeAutoUser

Kannst Du das Review machen?

@sidey79 sidey79 merged commit 962d656 into master Jan 15, 2022
@sidey79 sidey79 deleted the critic-check branch January 15, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants