Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md links to outdated thread on forum.fhem.de fixed #1053

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Jan 6, 2022

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

Fixes #957

  • What is the new behavior (if this is a feature change)?
  1. Link goes to Board and not to a thread
  2. Version number is up to date in readme
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

@sidey79 sidey79 self-assigned this Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1053 (2abc12f) into master (a828251) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   61.27%   61.34%   +0.07%     
==========================================
  Files         126      127       +1     
  Lines        9348     9353       +5     
  Branches     1479     1479              
==========================================
+ Hits         5728     5738      +10     
+ Misses       2546     2541       -5     
  Partials     1074     1074              
Flag Coverage Δ
fhem 52.52% <ø> (+0.02%) ⬆️
modules 61.34% <ø> (+0.07%) ⬆️
perl 91.83% <ø> (+0.21%) ⬆️
unittests 61.34% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/14_FLAMINGO/00_load.t 100.00% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.72% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a828251...2abc12f. Read the comment docs.

@sidey79 sidey79 merged commit 6cc7f28 into master Jan 8, 2022
@sidey79 sidey79 deleted the sidey79/issue957 branch January 23, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md links to outdated thread on forum.fhem.de
2 participants