Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong syntax in SIGNALduino_Parse_MN #1040

Merged
merged 3 commits into from
Dec 5, 2021
Merged

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    • wrong spelling does not lead to cancellation (return)
      --> test with MN;D=9005316X8000AABB;R=32; and manuelel modification comment out check $rmsg! ~ check

    • self error in RSSI check

    • wrong check on RSSI (Checking in Parse only allows decimal)
      --> test with MN;D=900531648000AABB;R=X2;

2021.11.29 22:58:02.912 4: sduino_dummy: get rawmsg: �MN;D=9005316X8000AABB;R=32;�
2021.11.29 22:58:02.938 3: sduino_dummy: Parse_MN, faulty rawData D=: 9005316X8000AABB
2021.11.29 22:58:02.938 1: PERL WARNING: Use of uninitialized value $rawData in concatenation (.) or string at ./FHEM/00_SIGNALduino.pm line 2915.
2021.11.29 22:58:02.964 4: sduino_dummy: Parse_MN, Error! id 100 msg=, no message_length provided
2021.11.29 22:58:02.990 4: sduino_dummy: Parse_MN, Error! id 101 msg=, no message_length provided
2021.11.29 22:58:03.009 4: sduino_dummy: Parse_MN, Error! id 102 msg=, no message_length provided
2021.11.29 22:58:03.027 4: sduino_dummy: Parse_MN, Error! id 103 msg=, no message_length provided
2021.11.29 22:58:03.046 4: sduino_dummy: Parse_MN, Error! id 108 msg=, no message_length provided
2021.11.29 22:58:03.064 4: sduino_dummy: Parse_MN, Error! id 112 msg=, no message_length provided
  • What is the new behavior (if this is a feature change)?
  • no error´s and code give return
    --> fault has been corrected
2021.11.29 23:04:49.272 4: sduino_dummy: get rawmsg: �MN;D=9005316X8000AABB;R=32;�
2021.11.29 23:04:49.291 3: sduino_dummy: Parse_MN, faulty msg: MN;D=9005316X8000AABB;R=32;
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

    • write error in the code (probably confused with bash)

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1040 (7ddffe3) into master (4f47ddb) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   61.42%   61.47%   +0.05%     
==========================================
  Files         127      126       -1     
  Lines        9332     9327       -5     
  Branches     1477     1477              
==========================================
+ Hits         5732     5734       +2     
+ Misses       2528     2521       -7     
  Partials     1072     1072              
Flag Coverage Δ
fhem 52.75% <100.00%> (+0.05%) ⬆️
modules 61.47% <100.00%> (+0.05%) ⬆️
perl 91.61% <ø> (ø)
unittests 61.47% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 63.81% <100.00%> (ø)
t/FHEM/14_SD_BELL/09_parseDatat.t
t/FHEM/14_SD_AS/00_load.t
t/FHEM/14_SD_UT/09_parseDatat.t 80.00% <0.00%> (ø)
FHEM/10_SD_Rojaflex.pm 71.54% <0.00%> (+2.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f47ddb...7ddffe3. Read the comment docs.

@HomeAutoUser HomeAutoUser merged commit fb86414 into master Dec 5, 2021
@HomeAutoUser HomeAutoUser deleted the master_Syntax_Parse_MN branch December 7, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants