Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaCrosse mode 1 optimization register settings #1022

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    GDO0 is defined as an output.
    Interrupt is only given in the FIFOTHR register specified number of bytes triggered (can only be set in steps of 4 bytes).
    16/16 + carrier-sense above threshold

  • What is the new behavior (if this is a feature change)?
    GDO0 output pin configuration, High impedance (3-state) - unused in FSK-modes
    CC1101 will wake up with optimal ADC settings for low data rate (≤ 100 kbps)
    The interrupt is triggered when the number of bytes required by the message is reached.
    SYNC_MODE 16/16 sync word bits detected

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

elektron-bbs and others added 4 commits October 4, 2021 20:45
SD_ProtocolData.pm
  Reg. 0x02 - IOCFG0 0x2E, GDO0 output pin configuration High impedance (3-state) - unused in FSK-modes
  Reg. 0x03 - FIFOTHR 0x41, Design Note DN009, FIFOTHR.ADC_RETENTION - CC1101 will wake up with optimal ADC settings for low data rate (≤ 100 kbps)
  Reg. 0x06 - PKTLEN 0x05 (5 Byte)
  Reg. 0x07 - PKTCTRL1 0x80, Preamble quality estimator threshold (2 Byte)
  Reg. 0x08 - PKTCTRL0 0x00, Fixed packet length mode. Length configured in PKTLEN register
  Reg. 0x12 - MDMCFG2 0x02, SYNC_MODE 16/16 sync word bits detected
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #1022 (4a4f00c) into master (c6d1c01) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   50.03%   50.01%   -0.02%     
==========================================
  Files         218      218              
  Lines       15279    15274       -5     
  Branches     2859     2859              
==========================================
- Hits         7645     7640       -5     
  Misses       5995     5995              
  Partials     1639     1639              
Flag Coverage Δ
fhem 50.24% <ø> (ø)
modules 50.01% <100.00%> (-0.02%) ⬇️
perl 50.95% <100.00%> (-0.03%) ⬇️
unittests 50.01% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
t/FHEM/00_SIGNALduino/01_SIGNALduino_Attr_rfmode.t 100.00% <ø> (ø)
t/SD_ProtocolData/01_verifyFSK.t 98.70% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d1c01...4a4f00c. Read the comment docs.

@elektron-bbs elektron-bbs merged commit c4ea61f into master Oct 4, 2021
@elektron-bbs elektron-bbs deleted the master_LaCrosseMode1-optRegister branch December 7, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants