Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warnings cc1101 Unittest #1008

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Fix Warnings cc1101 Unittest #1008

merged 2 commits into from
Aug 14, 2021

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Aug 13, 2021

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

The Unittest itself raises two warnings.
One Perl Warning and one TEST2 deprecated warning

  • What is the new behavior (if this is a feature change)?

Both warnings are fixed

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

fix a warning in tests
@sidey79 sidey79 changed the title cc1101/01_func.t Fix Warnings cc1101 Unittest Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1008 (dd030c2) into master (32f966a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   49.48%   49.49%           
=======================================
  Files         217      217           
  Lines       15182    15182           
  Branches     2841     2841           
=======================================
+ Hits         7513     7514    +1     
+ Misses       6053     6052    -1     
  Partials     1616     1616           
Flag Coverage Δ
fhem 49.31% <ø> (ø)
modules 49.49% <ø> (+<0.01%) ⬆️
perl 50.77% <ø> (+0.01%) ⬆️
unittests 49.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/cc1101/01_func.t 100.00% <ø> (ø)
local/lib/perl5/Test2/Util/HashBase.pm 48.43% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f966a...dd030c2. Read the comment docs.

@sidey79
Copy link
Contributor Author

sidey79 commented Aug 14, 2021

@HomeAutoUser
Ich musste den Branch vor dem merge Updaten

@sidey79 sidey79 merged commit e7d9da0 into master Aug 14, 2021
@sidey79 sidey79 deleted the fix-warning branch August 14, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants