Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoupdate CHANGED file only on master branch #1004

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Aug 8, 2021

Changed is only updated action rruns on master branch

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • [] Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

Changed is updated for all pushes, where no pull request can be found.
This will happen always for the first push.

  • What is the new behavior (if this is a feature change)?

Changed will only be updated on the master branch and not for feature branches

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

we will see, i don't hope

  • Other information:

Changed is only updated action rruns on master branch
@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #1004 (5726682) into master (a1891fa) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   49.48%   49.49%           
=======================================
  Files         217      217           
  Lines       15184    15184           
  Branches     2841     2841           
=======================================
+ Hits         7514     7515    +1     
+ Misses       6054     6053    -1     
  Partials     1616     1616           
Flag Coverage Δ
fhem 49.32% <ø> (ø)
modules 49.49% <ø> (+<0.01%) ⬆️
perl 50.76% <ø> (+0.01%) ⬆️
unittests 49.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
local/lib/perl5/Test2/Util/HashBase.pm 46.87% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1891fa...5726682. Read the comment docs.

@sidey79 sidey79 changed the title Update update.yml Autoupdate CHANGED file only on master branch Aug 8, 2021
HomeAutoUser
HomeAutoUser previously approved these changes Aug 8, 2021
@sidey79
Copy link
Contributor Author

sidey79 commented Aug 8, 2021

Ich denke ich muss das erst noch ausprobieren, bevor wir es mergen. Bin zwar sicher, dass es klappt aber ausprobieren hilft

Fix Variable name
@sidey79
Copy link
Contributor Author

sidey79 commented Aug 10, 2021

@HomeAutoUser

Ich habe es getestet, dass es funktioniert. Wenn Du noch mal genehmigen könntest

@sidey79 sidey79 merged commit a3a967a into master Aug 10, 2021
@sidey79 sidey79 deleted the fix-changed-updates branch January 23, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants