feat(qp): introduce more wrapper types and refactor qp_ex implementation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonJACson
force-pushed
the
dev/qp-trait
branch
3 times, most recently
from
79b3b5e to
e923595
Compare
dragonJACson
changed the title
dragonJACson
changed the title
FujiZ
reviewed
Sep 17, 2024
dragonJACson
force-pushed
the
dev/qp-trait
branch
2 times, most recently
from
1ad3335 to
73f7aff
Compare
We introduce AccessFlags as a wrapper type for ibv_access_flags in this commit. As flags would be used for MemoryRegion and QueuePair at the same time, we put it in the verbs/mod.rs. Signed-off-by: Luke Yue <lukedyue@gmail.com>
We introduce SendOperationFlags for building qp_ex, by default, we would create an extended qp with write / send / read support, just like what a basic qp supports. At the same time, we put `NonNull<ibv_qp_ex>` in ExtendedQueuePair instead of `NonNull<ibv_qp>`, this should be more accurate. Signed-off-by: Luke Yue <lukedyue@gmail.com>
dragonJACson
force-pushed
the
dev/qp-trait
branch
from
73f7aff to
18cebbb
Compare
FujiZ
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce wrapper types for
ibv_access_flagsandsend_ops_flagsin this commit, maybeibv_qp_init_attr_maskshould be wrapped too?At the same time, we replaced the
NonNull<ibv_qp>inExtendedQueuePairwithNonNull<ibv_qp_ex>, which should make more sense. By default, extended qp would support write / send / read.