Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove print() calls from SPARQL algebra code #2553

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix: remove print() calls from SPARQL algebra code #2553

merged 1 commit into from
Aug 28, 2023

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Aug 28, 2023 •
edited
Loading

Summary of changes

These print() are not needed and also pollute the output of code that
uses RDFLib.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
fix: remove print() calls from SPARQL algebra code
c88ac9c 
These `print()` are not needed and also pollute the output of code that
uses RDFLib.

- Fixes <RDFLib#2552>.
@aucampia aucampia force-pushed the aucampia/20230828T1844-remove-prints branch from f77576f to c88ac9c Compare August 28, 2023 16:59
@aucampia aucampia requested a review from a team August 28, 2023 16:59
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Aug 28, 2023
@coveralls
Copy link

Coverage Status

coverage: 90.934% (-0.001%) from 90.935% when pulling c88ac9c on aucampia:aucampia/20230828T1844-remove-prints into 079f388 on RDFLib:main.

@aucampia aucampia merged commit 4d01b3a into RDFLib:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

algebra translator emitting print statements
2 participants
@aucampia @coveralls