Fix "Kills by Auto-Titan" not registering at all #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
approved these changes
Jul 12, 2024
|
I guess for testing just get another player and have them be killed by auto-titan? ^^ |
GeckoEidechse
added
needs testing
|
Tested in my own server by hosting Attrition and FD, so far no crashes in regards to this, and my titan started registering its kills in my profile: |
|
Good enough for me ^^ |
GeckoEidechse
removed
needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix that will redirect the attacker entity to a proper NPC owned by the player.
By default behavior of the game, attackers are always the final entity in the owning hiearchy, which is always a player if owned NPCs kills enemies.
This PR properly redirects the code to the correct NPC whenever they have an owning player.