Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of Autohook from rejectconnectionfixes.cpp #793

Merged

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Honestly, this is a difficult one to test functionality for... I guess the hook being created will have to do?

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 29, 2024
Copy link

@xFrannM xFrannM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR tested and working fine. I checked log files, specifically the hooks working.
Enabling hook COM_ExplainDisconnection didn't appear (which is fine)

@GeckoEidechse GeckoEidechse added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs code review Changes from PR still need to be reviewed in code and removed needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested labels Aug 29, 2024
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🐱

@F1F7Y F1F7Y merged commit db353e6 into R2Northstar:main Aug 30, 2024
5 checks passed
@F1F7Y F1F7Y removed needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Aug 30, 2024
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/rejectconnectionfixes.cpp branch September 5, 2024 12:51
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
…orthstar#793)

Removes AUTOHOOK macro from `rejectconnectionfixes.cpp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants