Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscript: Move squirrel types to their respective files #788

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Aug 27, 2024

Mostly taken from primedev, just moves some structs around.

Things to test:

  • Does the video game run
  • Do script commands work (ei script_client, script, ...)
  • Idk

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance, comes sorta free with some better struct/class definitions as well.

Disclaimer: I did not go and verify that the memory layout of all of the structs matches up with the previous ones. That would take too long and gets verified anyway with testing later for the most part.

@ASpoonPlaysGames ASpoonPlaysGames added the needs testing Changes from the PR still need to be tested label Aug 29, 2024
@GeckoEidechse GeckoEidechse self-assigned this Aug 31, 2024
@GeckoEidechse GeckoEidechse changed the title vscript: move squirrel types to their respective files vscript: Move squirrel types to their respective files Sep 2, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the change locally to better understand it. Got it to almost match. Noticed that there a few more changes than just moving code around like adjusting existing structs with new fields that have been reversed since.
Would have been nice to have that as a separate change but oh well.

Otherwise I didn't notice any obvious issues but I also didn't go super in-depth.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launched private match with this PR and ran

sv_cheats 1
script AddPlayerScore(GetPlayerArray()[0], "KillPilot")

and everything still worked as expected.

@GeckoEidechse
Copy link
Member

This one is gonna require a lot more extensive testing to actually verify correctness. That's not gonna happen. So the best we can do is just test in prod and hope that any issues get reported back to us (no remote logging to do that automatically ;-;)

@GeckoEidechse GeckoEidechse merged commit ce21abe into R2Northstar:main Sep 2, 2024
4 checks passed
@GeckoEidechse GeckoEidechse removed their assignment Sep 24, 2024
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Oct 5, 2024
Refactor logic to move Squirrel types to their own respective files and extend existing layouts in the process where applicable.
Contains additional smaller fixes.
wolf109909 added a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Changes from the PR still need to be tested
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants