-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscript: Move squirrel types to their respective files #788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at a glance, comes sorta free with some better struct/class definitions as well.
Disclaimer: I did not go and verify that the memory layout of all of the structs matches up with the previous ones. That would take too long and gets verified anyway with testing later for the most part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproduced the change locally to better understand it. Got it to almost match. Noticed that there a few more changes than just moving code around like adjusting existing structs with new fields that have been reversed since.
Would have been nice to have that as a separate change but oh well.
Otherwise I didn't notice any obvious issues but I also didn't go super in-depth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Launched private match with this PR and ran
sv_cheats 1
script AddPlayerScore(GetPlayerArray()[0], "KillPilot")
and everything still worked as expected.
This one is gonna require a lot more extensive testing to actually verify correctness. That's not gonna happen. So the best we can do is just test in prod and hope that any issues get reported back to us (no remote logging to do that automatically ;-;) |
Refactor logic to move Squirrel types to their own respective files and extend existing layouts in the process where applicable. Contains additional smaller fixes.
…thstar#788)" This reverts commit c3371d7.
Mostly taken from primedev, just moves some structs around.
Things to test:
script_client
,script
, ...)