Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix status command and add UID to status output #189

Closed
wants to merge 9 commits into from

Conversation

TH3-S4LM0N
Copy link

Made this for rolesspawn cause github
It adds UIDs to the status command and makes it work again, like Counter-Strike: Source. I noticed it was missing in Northstar, so I broke out a debugger to figure out why. It turns out some commands are "engine client" commands, and the existing console command check didn't check for those. I tried to copy the codestyle I saw in other files, so please let me know if I made any mistakes.

@GeckoEidechse
Copy link
Member

Response to above comments on Discord by commit author:
https://discord.com/channels/920776187884732556/950322078945538058/986267580526374952

Copy link
Contributor

@p0358 p0358 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine now, the list of allowed concommands should be harmless, and the commands that are allowed and where they're defined in engine.dll is now commented above the declaration of CGameClient__IsEngineClientCommand for easy review of what that command checks in case someone needs to revisit concommands stuff in the future

@p0358
Copy link
Contributor

p0358 commented Jun 15, 2022

Here's some extra context to the approval from discord to future readers: https://discord.com/channels/920776187884732556/950322078945538058/986267580526374952

@GeckoEidechse
Copy link
Member

Closing as @rolelessweapon now has sufficient access to open PRs under her own name.

@rolelessweapon please open new PR with the same branch and link to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants