Skip to content

Commit

Permalink
Full rebuild
Browse files Browse the repository at this point in the history
  • Loading branch information
RLumSK committed Jun 12, 2020
1 parent 277a8e1 commit ddbd394
Show file tree
Hide file tree
Showing 43 changed files with 152 additions and 190 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: RLumCarlo
Type: Package
Title: Monte-Carlo Methods for Simulating Luminescence Phenomena
Version: 0.1.4
Date: 2020-06-06
Version: 0.1.5
Date: 2020-06-12
Author: Johannes Friedrich [aut, trl] (<https://orcid.org/0000-0002-0805-9547>),
Sebastian Kreutzer [aut, trl, cre] (<https://orcid.org/0000-0002-0734-2199>),
Vasilis Pagonis [aut] (<https://orcid.org/0000-0002-4852-9312>),
Expand Down
3 changes: 1 addition & 2 deletions NEWS.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ header-includes:

## RLumCarlo `r RLumBuild::.get_pkg_version()` (`r Sys.Date()`)

* Add automated spell correction and remove odd DOIs and not yet
valid links to ease the CRAN inspection
* Fix problem on CRAN Solaris

## RLumCarlo 0.1.3 (2020-06-05) (never published on CRAN)

Expand Down
4 changes: 2 additions & 2 deletions NEWS.html
Original file line number Diff line number Diff line change
Expand Up @@ -602,9 +602,9 @@

<!-- NEWS.md was auto-generated by NEWS.Rmd. Please DO NOT edit by hand!-->

<h2 id="rlumcarlo-014-2020-06-06">RLumCarlo 0.1.4 (2020-06-06)</h2>
<h2 id="rlumcarlo-015-2020-06-12">RLumCarlo 0.1.5 (2020-06-12)</h2>
<ul>
<li>Add automated spell correction and remove odd DOIs and not yet valid links to ease the CRAN inspection</li>
<li>Fix problem on CRAN Solaris</li>
</ul>
<h2 id="rlumcarlo-013-2020-06-05-never-published-on-cran">RLumCarlo 0.1.3 (2020-06-05) (never published on CRAN)</h2>
<ul>
Expand Down
5 changes: 2 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@

<!-- NEWS.md was auto-generated by NEWS.Rmd. Please DO NOT edit by hand!-->

## RLumCarlo 0.1.4 (2020-06-06)
## RLumCarlo 0.1.5 (2020-06-12)

- Add automated spell correction and remove odd DOIs and not yet valid
links to ease the CRAN inspection
- Fix problem on CRAN Solaris

## RLumCarlo 0.1.3 (2020-06-05) (never published on CRAN)

Expand Down
4 changes: 2 additions & 2 deletions README.html

Large diffs are not rendered by default.

Binary file not shown.
Binary file removed RLumCarlo.BuildResults/RLumCarlo_0.1.4.tar.gz
Binary file not shown.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ @Manual{
title = {RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena},
author = {Johannes Friedrich and Sebastian Kreutzer and Vasilis Pagonis and Christoph Schmidt},
year = {2020},
note = {R package version 0.1.4},
note = {R package version 0.1.5},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,119 +3,134 @@ @InCollection{
title = {create_ClusterSystem(): Create dosimetric cluster system},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {methods_RLumCarlo(): methods_RLumCarlo},
volume = {version: },
author = {Kreutzer S and Friedrich J},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {plot_RLumCarlo(): Plot RLumCarlo Monte-Carlo Simulation Results},
volume = {version: 0.1.0},
author = {Kreutzer S and Friedrich J},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_CW_IRSL_LOC(): Monte-Carlo Simulation for CW-IRSL (localized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_CW_IRSL_TUN(): Run Monte-Carlo Simulation for CW-IRSL (tunnelling transitions)},
volume = {version: 0.2.0},
author = {Friedrich J and Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_CW_OSL_DELOC(): Run Monte-Carlo Simulation for CW-OSL (delocalized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_ISO_DELOC(): Run Monte-Carlo Simulation for ISO-TL (delocalized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_ISO_LOC(): Run Monte-Carlo simulation for ISO-TL (localized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_ISO_TUN(): Monte-Carlo Simulation for ISO-TL (tunnelling transitions)},
volume = {version: 0.1.0},
author = {Friedrich J and Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_LM_OSL_DELOC(): Run Monte-Carlo Simulation for LM-OSL (delocalized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_LM_OSL_LOC(): Run Monte-Carlo Simulation for LM-OSL (localized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_LM_OSL_TUN(): Run Monte-Carlo Simulation for LM-OSL (tunnelling transitions)},
volume = {version: 0.1.0},
author = {Friedrich J and Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_TL_DELOC(): Run Monte-Carlo Simulation for TL (delocalized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_TL_LOC(): Run Monte-Carlo Simulation for TL (localized transitions)},
volume = {version: 0.1.0},
author = {Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
@InCollection{,
title = {run_MC_TL_TUN(): Run Monte-Carlo Simulation for TL (tunnelling transitions)},
volume = {version: 0.1.0},
author = {Friedrich J and Kreutzer S},
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.4. },
booktitle = {Friedrich, J., Kreutzer, S., Pagonis, V., Schmidt, C., 2020. RLumCarlo: Monte-Carlo Methods for Simulating Luminescence Phenomena. R package version 0.1.5.},
publisher = {RLumCarlo},
year = {2020},
url = {https://CRAN.R-project.org/package=RLumCarlo},
}
Binary file not shown.
Binary file added RLumCarlo.BuildResults/RLumCarlo_0.1.5.tar.gz
Binary file not shown.
11 changes: 9 additions & 2 deletions codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"codeRepository": "https://CRAN.R-project.org/package=RLumCarlo",
"issueTracker": "https://github.com/R-Lum/RLumCarlo/issues",
"license": "https://spdx.org/licenses/GPL-3.0",
"version": "0.1.4",
"version": "0.1.5",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down Expand Up @@ -253,5 +253,12 @@
"https://travis-ci.org/R-Lum/RLumCarlo",
"https://ci.appveyor.com/project/RLumSK/rlumcarlo",
"https://codecov.io/gh/R-Lum/RLumCarlo"
]
],
"provider": {
"@id": "https://cran.r-project.org",
"@type": "Organization",
"name": "Comprehensive R Archive Network (CRAN)",
"url": "https://cran.r-project.org"
},
"relatedLink": "https://CRAN.R-project.org/package=RLumCarlo"
}
66 changes: 4 additions & 62 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,71 +1,13 @@
Dear CRAN-Team,

This replaces RLumCarlo v0.1.3 currently under inspection by the CRAN Team.
This fixes the error message for the CRAN Solaris check ressource flagged
thanks to Prof Ripley.

After my submission yesterday, I realised a couple of other problems with links and possibly misspelt words. This will likely lead to another rejection of my submission.
The following measures are now implemented, to avoid wasting more time of the CRAN Team:

* The package now uses a WORDLIST and unit test with the package 'spelling'
* All flagged misspelt words were corrected
* I removed all 'bad' DOIs from the manual, except for the DESCRIPTION file (where it was requested by the CRAN Team).
* The corresponding references are still correctly mentioned in the manual, but not anymore linked through a DOI. However, I notified the publisher, and I will add these DOIs again as soon as the underlying problem got solved.

Thank you very much for your patience and support!

On behalf of the RLumCarlo package developer team, best wishes,
Thank you for your support and on behalf of the RLumCarlo package developer team,
best wishes,

Sebastian Kreutzer

## Responses to 3rd rejection

> Possibly mis-spelled words in DESCRIPTION:
> linerarly (32:5)
Done and I am very sorry for the extra round and the trouble.

## Responses to 2nd rejection

> Please always use the canonical link for R packages.
> Please fix and resubmit, and document what was changed in the submission comments.
The flagged link was: `https://www.r-pkg.org/pkg/RLumCarlo`.

This is **not** a link, this is the URL to retrive the badge:

`[![CRAN](https://www.r-pkg.org/badges/version/RLumCarlo)](https://cran.r-project.org/package=RLumCarlo)`

If you click on the badge the site link is: https://cran.r-project.org/package=RLumCarlo
To be sure, I changed it now to `https://CRAN.R-project.org/package=RLumCarlo`.
Obviosuly it does not change the URL, but maybe this is what was meant.


## Responses to 1st rejection

> If there are references describing the (theoretical background of) methods in your package, please add these in the Description field of your DESCRIPTION file in the form
> authors (year) <doi:...>
> authors (year) <arXiv:...>
> authors (year, ISBN:...)
> with no space after 'doi:', 'arXiv:' and angle brackets for auto-linking.
Done.

> Please replace \dontrun{} by \donttest{} or unwap the examples if they can be
executed in less than 5 sec per Rd-file.

Nothing done. We have at least one running example per function (not wrapped
in `\dontrun{}`) If we wrapped something in `\dontrun{}` it was because
it exceeded this 5 s but we wanted to provide some longer examples
(obviously it depends a little bit on the computer,
but we did not want to push it too far and overcharge CRAN resources).
More examples can be found in the vignette.

>You are changing the user's par() settings in your functions. Please ensure with an immediate call of on.exit() that the settings are reset. E.g.
> opar <- par(no.readonly =TRUE) # code line i
> on.exit(par(opar)) # code line i+1
Added as requested in code-lines 120-121 in `plot_RLumCarlo()` (the only
function that produces a plot output).

## R CMD check --as-cran results

0 errors | 0 warnings | 1 note
Expand Down
2 changes: 1 addition & 1 deletion man/create_ClusterSystem.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified man/figures/README-unnamed-chunk-2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion man/methods_RLumCarlo.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/plot_RLumCarlo.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/run_MC_CW_IRSL_LOC.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/run_MC_CW_IRSL_TUN.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/run_MC_CW_OSL_DELOC.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ddbd394

Please sign in to comment.