Replace the implementation of .throw_error() and .throw_warning() #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the fn_stack list to .LuminescenceEnv, as well as functions .set_function_name() and .unset_function_name() that manage it.
…ing functions. This is in preparation of switching .throw_error() and .throw_warning() to use the .LuminescenceEnv$fn_stack list, for the moment they still behave as before.
This was missed in dee4f4f.
Rather than relying on the parsing of sys.call() and the setting of the correct nframe value, this uses the most up-to-date function name stored in the .LuminescenceEnv list.
|
Thanks @mcol: It makes sense and I do agree that this additional lines make sense. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts the last approach I mentioned in #254. It has some advantages on what we have right now:
sys.call()which as we've seen can be fragilenframeto pick the correct stack frame into which look for the function name.throw_error()and.throw_warning()is now straightforwardThere is one minor disadvantage:
The example with
subsetdiscussed in #254 now returns:[get_RLum()] Invalid subset expression, valid terms are: curveType, recordTypewhich is fine, as
subset()is just an S3 method that dispatches toget_RLum()for the actual subsetting.I've broken this up in several commits for easier review. Only on the last commit we actually switch to the new approach, which means that at all points tests still pass (at least locally).
Fixes #254.