Fix crashes in analyse_SAR.TL() #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If calc_TLLxTxRatio() fails, then we get a garbled error message:
Error in h(simpleError(msg, call)) :
error in evaluating the argument 'object' in selecting a method for
function 'get_RLum':
[calc_TLLxTxRatio()] Data types of Lx and Tx data differ
The code that creates the RejectionCriteria data frame has been entirely
rewritten using data.table, resulting in cleaner and also more performant
code.
Moreover, this change allows to solve an additional testcase:
analyse_SAR.TL(object, dose.points = 2,
signal.integral.min = 210, signal.integral.max = 220,
sequence.structure = c("SIGNAL", "BACKGROUND"))
which previously failed with:
Error in dimnames(x) <- dn :
length of 'dimnames' [2] not equal to array extent
due to the use of sapply(), which in this case ended up producing a matrix
instead of a vector.
RLumSK
approved these changes
Sep 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks a bit complicated as there's some code cleanup that was necessary to better understand what was going on in this function. However, looking at each single commit should make it much easier to understand.
Fixes #147.