Correct the rejection.criteria data frame created by analyse_SAR.TL() #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLumSK
approved these changes
Sep 16, 2024
Replace UTF8 by ASCII
RLumSK
approved these changes
Sep 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses all correctness issues pointed out in #245. Having the snapshot was invaluable to find the problems, and now it makes it visually easier to see what has actually changed.
Much of this code is overly complicated, but I'm cleaning it up separately.
Note: I've used
NA_real_andNA_character_as I'm going to usedata.tableto simplify it, and for that it really matter that the column have the correct type, otherwise it's not possible to bind them together.Fixes #245.