Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make interactive mode in plot_AbanicoPlot() functional again #233

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Make interactive mode in plot_AbanicoPlot() functional again #233

merged 1 commit into from
Sep 11, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Sep 11, 2024

This required a few little changes:

  • variables are now named via formula so that they can be looked up in the dataset of interest for each trace
  • when hovertext = "none" is set, I've also added text = "", as otherwise there would be a dimension mismatch, as text would otherwise be inherited from the main plot object
  • the creation of the KDE.text referenced the wrong object
  • </br> didn't create a newline in the hovered text, I've replaced it with <br />

The plot is now functional, although is not quite as complete as the non-interactive plot, but that seems expected, as there's no code present to draw the other elements. Fixes #220.

@RLumSK RLumSK merged commit bbb7856 into R-Lum:dev_0.9.x Sep 11, 2024
10 checks passed
@mcol mcol deleted the issue_220 branch September 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants