Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using interactive mode for plot_Histogram() #231

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix crash when using interactive mode for plot_Histogram() #231

merged 1 commit into from
Sep 11, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Sep 10, 2024

Fixes the crash reported in #186. However, the graph doesn't appear interactive at all (I checked with RStudio).

This fixes a crash when using the interactive mode and fixes problems due
to updates in plotly package.
@mcol
Copy link
Contributor Author

mcol commented Sep 11, 2024

I've pushed a newer fix that actually makes the plot fully functional again. There were two main issues, besides those that caused the crash:

  • names of variables are not looked up automatically in the dataset, so I went with specifying them as formulas, such as ~x
  • now by default attributes are inherited by the traces, but for us the histnorm attribute was incompatible in the scatter traces: that is solved by setting inherit = FALSE in the traces

@RLumSK RLumSK merged commit e00a5f2 into R-Lum:dev_0.9.x Sep 11, 2024
10 checks passed
@mcol mcol deleted the issue_186 branch September 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants