Make calc_WodaFuchs2008() work on more RLum.Results objects #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some RLum.Results objects may not contain the "data" slot, such as those produced by calc_WodaFuchs2008() itself. In such case we revert to taking the first slot, as in general it's the most meaningful.
With just one data point, it's possible to cause nls() to hang, so we don't allow that.
RLumSK
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick and dirty fix for the example posted in #199.
I ended up with the
tryCatch()solution because in the tests we have already an example in which thedataslot is present but it's not the first entry:In other words, with my approach we don't change the expectation of that test.