Validate signal and background integral values in plot_DetPlot() #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enforcing that
signal.integral.max > signal.integral.min
we also avoid that the computation of the number of channels producesInf
(fixes #203).Locally, running coverage on this produces this error from the test that uses
multicore = 1
:That error would go away if I used
Luminescence:::.validate_positive_scalar
, but that seems to be against the CRAN policy. Alternatively, one could move the validation checks before the self-call.But in the meantime, let's see if CI is happy with it as it is.