Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More coverage and fixes #164

Merged
merged 7 commits into from
Aug 22, 2024
Merged

More coverage and fixes #164

merged 7 commits into from
Aug 22, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Aug 22, 2024

Concerns these files (part of #121):

  • analyse_SAR.CWOSL.R
  • calc_AverageDose.R
  • calc_Huntley2006.R
  • fit_EmissionSpectra.R
  • fit_SurfaceExposure.R
  • read_Daybreak2R.R

This also restores the graphical parameters at the end of test_combine_De_Dr.R and allows to reinstate a plot in test_fit_EmissionSpectra.R that used to fail, fixing #161.

Copy link
Member

@RLumSK RLumSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @mcol, looks good to me so far, I will just wait for the tests to finish.

@RLumSK RLumSK merged commit 6cd8cae into R-Lum:dev_0.9.x Aug 22, 2024
10 checks passed
@mcol mcol deleted the coverage_10 branch August 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants