Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from fit_SurfaceExposure() if data contains NAs #163

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Remove warnings from fit_SurfaceExposure() if data contains NAs #163

merged 3 commits into from
Aug 21, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Aug 21, 2024

Fixes a dimension mismatch in fit_SurfaceExposure() when the input data contains NAs, by removing them before subsetting the data further. Fixes #162.

mcol and others added 3 commits August 21, 2024 17:02
Fixes a dimension mismatch if the input data contains NAs, by removing them
before subsetting the data further. Fixes #162.
Add name of function
Make sure the functions name does not break the test
Copy link
Member

@RLumSK RLumSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcol. I've made two changes regarding the function name. The test is fine.

@RLumSK RLumSK merged commit a95bf51 into R-Lum:dev_0.9.x Aug 21, 2024
10 checks passed
@RLumSK
Copy link
Member

RLumSK commented Aug 21, 2024

Fix #162

@mcol mcol deleted the issue_162 branch August 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants