Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate the input_scale argument in fit_EmissionSpectra() #160

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Propagate the input_scale argument in fit_EmissionSpectra() #160

merged 1 commit into from
Aug 21, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Aug 21, 2024

Argument input_scale was not propagated in the self-call, so it was effectively ignored in most cases.

RLumSK
RLumSK approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@RLumSK RLumSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcol

@RLumSK RLumSK merged commit bcf69c0 into R-Lum:dev_0.9.x Aug 21, 2024
10 checks passed
@mcol mcol deleted the init_value branch August 21, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RLumSK RLumSK RLumSK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcol @RLumSK