Fix .throw_error() and .throw_warning() #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems with the current implementation of
.throw_error()
and.throw_warning()
which were noted in #152:This PR makes the function print the name of the calling function just once and allows using them from other internal functions, thanks to the new
nframe
argument that allows to control which function name is reported from the error/warning message.When
.throw_error()/.throw_warning()
are called from an exported Luminescence function, one can use these two functions without worrying aboutnframe
, they will work by default as expected. The only time that we should setnframe = 2
is when we use the throwing functions from an internal function, such as in.validate_positive_scalar()
.