Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up input validation in calc_FiniteMixture() #142

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Clean up input validation in calc_FiniteMixture() #142

merged 1 commit into from
Aug 14, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Aug 14, 2024

Various cleanups found while I was looking at this function:

  • simplified and streamlined a bit the logic for input validation
  • changed the occurrences of cat(paste("error message")); stop(domain = NA) to stop("error message", call. = FALSE), which makes it easier to test and is what is more commonly used
  • adjusted a bit the error messages
  • expanded tests on inputs

@RLumSK RLumSK merged commit dc1ea56 into R-Lum:dev_0.9.x Aug 14, 2024
10 checks passed
@mcol mcol deleted the calc_FiniteMixture branch August 15, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants