Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyse_SAR.CWOSL() ... regression bug due to aliquot number assignment #373

Closed
RLumSK opened this issue Oct 30, 2024 · 0 comments
Closed

analyse_SAR.CWOSL() ... regression bug due to aliquot number assignment #373

RLumSK opened this issue Oct 30, 2024 · 0 comments
Assignees
@RLumSK
Labels
bug (regression) Bug introduced with a recent add or fix
Milestone
v0.9.26

Comments

@RLumSK
Copy link
Member

RLumSK commented Oct 30, 2024

Describe the bug
The function crashes with

Error in `$<-.data.frame`(`*tmp*`, "ALQ", value = 1:2) : 
  replacement has 2 rows, data has 1

if a list of RLum.Analysis objects is provided and one contains only TL curves (typical for single grain data), which is filtered automatically. This is because the function working over a list tries to add the aliquot number and this failed because of different lengths.
@RLumSK RLumSK added the bug (regression) Bug introduced with a recent add or fix label Oct 30, 2024
@RLumSK RLumSK added this to the Release version 1.0.0 milestone Oct 30, 2024
@RLumSK RLumSK self-assigned this Oct 30, 2024
@RLumSK RLumSK closed this as completed in 533d837 Oct 30, 2024
@mcol mcol mentioned this issue Nov 14, 2024
Closed
mcol pushed a commit that referenced this issue Nov 15, 2024
@RLumSK @mcol
Fix #373
cefe19b 
+ fx the single that caused the issue
+ ad a dedicated test
+ ad NEWS
+ up NEWS
o no manual update - regression
@mcol mcol modified the milestones: Release version 1.0.0, v0.9.26 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RLumSK RLumSK

Labels
bug (regression) Bug introduced with a recent add or fix
Projects
None yet
Milestone
v0.9.26
Development

No branches or pull requests
2 participants
@mcol @RLumSK