Skip to content

Commit

Permalink
Update cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
Browse files Browse the repository at this point in the history
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
  • Loading branch information
R-JunmingChen and pitrou authored Oct 19, 2023
1 parent af93cbf commit be9238e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,9 @@ struct DictionaryMinMaxImpl : public ScalarAggregator {
}
this->has_nulls |= compacted_dict_arr.null_count() > 0;
this->count += compacted_dict_arr.length() - compacted_dict_arr.null_count();

if (this->has_nulls && !options.skip_nulls) {
return Status::OK();
}
std::shared_ptr<Scalar> dict_min;
std::shared_ptr<Scalar> dict_max;
if (compacted_dict_arr.length() - compacted_dict_arr.null_count() == 1) {
Expand Down

0 comments on commit be9238e

Please sign in to comment.